[Tarantool-patches] [PATCH v4 12/16] sql: refactor MIN() and MAX() functions

[Mergen Imeev]

Thank you for the review! My asnwer below.

On Mon, Oct 04, 2021 at 11:54:10PM +0200, Vladislav Shpilevoy wrote:
> Good job on the fixes!
> 
> > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> > index a3d403176..96eb76244 100644
> > --- a/src/box/sql/vdbe.c
> > +++ b/src/box/sql/vdbe.c
> > @@ -4161,7 +4161,6 @@ case OP_AggStep: {
> >  	}
> >  #endif
> >  
> > -	pMem->n++;
> 
> Could you please remind me why is it dropped in this commit?
I dropped this because it affects the result of the MIN()/MAX() functions. Prior
to this patch-set, each aggregate MEM contained one special structure. They each
have a constant size, so mem->n could have been and was used for something else.
However, I have no idea why it was here or what it was used for.