[Tarantool-patches] [PATCH v1 1/1] sql: define default types for built-in functions
Mergen Imeev
imeevma at tarantool.org
Fri Nov 19 11:15:57 MSK 2021
Thank you for the review! My answer below.
On Mon, Nov 15, 2021 at 10:53:25PM +0100, Vladislav Shpilevoy wrote:
> Thanks for the patch!
>
> > +test:do_test(
> > + "builtins-4.6",
> > + function()
> > + local res = {pcall(box.execute, [[SELECT LENGTH(?);]], {1})}
> > + return {tostring(res[3])}
>
> Don't we usually use do_catchsql_test for such tests? The same for
> 4.9, 4.13, 4.14.
We do, but do_catchsql_test() does not support bindings, so we have to write tests like this.
More information about the Tarantool-patches
mailing list