[Tarantool-patches] [PATCH v1 14/21] sql: refactor UNICODE() function

Mergen Imeev imeevma at tarantool.org
Tue Nov 2 14:42:09 MSK 2021

Thank you for the review! I fixed the type of the argument passed to the U8_NEXT
macro. Diff below.

On Mon, Oct 25, 2021 at 11:40:47AM +0300, Mergen Imeev via Tarantool-patches wrote:


diff --git a/src/box/sql/func.c b/src/box/sql/func.c
index 7e53cc1ce..69d4e7347 100644
--- a/src/box/sql/func.c
+++ b/src/box/sql/func.c
@@ -1049,7 +1049,7 @@ func_unicode(struct sql_context *ctx, int argc, struct Mem *argv)
 		return mem_set_uint(ctx->pOut, 0);
 	int pos = 0;
 	UChar32 c;
-	U8_NEXT(arg->z, pos, arg->n, c);
+	U8_NEXT((uint8_t *)arg->z, pos, arg->n, c);
 	mem_set_uint(ctx->pOut, (uint64_t)c);

More information about the Tarantool-patches mailing list