[Tarantool-patches] [PATCH 1/1] sql: introduce UUID field type
Mergen Imeev
imeevma at tarantool.org
Thu May 27 19:40:55 MSK 2021
Hi! Thank you for the review! My answer and diff below. Also, I plan to send you
this patch one more time as part of patch-set, that contains this patch and
patch that introduces SQL built-in function uuid().
On Tue, May 25, 2021 at 11:50:45PM +0200, Vladislav Shpilevoy wrote:
> Nice fixes!
>
> > diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c
> > index a518fd0c6..9a6689d7d 100644
> > --- a/src/box/sql/mem.c
> > +++ b/src/box/sql/mem.c
> > @@ -81,6 +91,8 @@ mem_str(const struct Mem *mem)
> > case MEM_TYPE_MAP:
> > case MEM_TYPE_ARRAY:
> > return mp_str(mem->z);
> > + case MEM_TYPE_UUID:
> > + return tt_sprintf("%s", tt_uuid_str(&mem->u.uuid));
>
> You don't need tt_sprintf() either. You need to simply
> return tt_uuid_str().
Thanks, fixed.
Diff:
diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c
index 9a6689d7d..2ad104e1b 100644
--- a/src/box/sql/mem.c
+++ b/src/box/sql/mem.c
@@ -92,7 +92,7 @@ mem_str(const struct Mem *mem)
case MEM_TYPE_ARRAY:
return mp_str(mem->z);
case MEM_TYPE_UUID:
- return tt_sprintf("%s", tt_uuid_str(&mem->u.uuid));
+ return tt_uuid_str(&mem->u.uuid);
case MEM_TYPE_BOOL:
return mem->u.b ? "TRUE" : "FALSE";
default:
More information about the Tarantool-patches
mailing list