[Tarantool-patches] [PATCH 1/1] json: use cord_ibuf for encoding and decoding
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon May 24 18:47:03 MSK 2021
Thanks for the review!
> Sorry, I noticed this too late: luacheck has one warning on your branch:
>
> Checking test/app-tap/json.test.lua 1 warning
> 422 <https://github.com/tarantool/tarantool/runs/2650197964#step:4:422>
> 423 <https://github.com/tarantool/tarantool/runs/2650197964#step:4:423>test/app-tap/json.test.lua:210:9: (W213) unused loop variable i
> 424 <https://github.com/tarantool/tarantool/runs/2650197964#step:4:424>
Fixed:
====================
@@ -207,7 +207,7 @@ tap.test("json", function(test)
--
local bigstr = string.rep('a', 16384)
local t = {}
- for i = 1, 10 do
+ for _ = 1, 10 do
table.insert(t, bigstr)
end
local bigjson = serializer.encode(t)
====================
More information about the Tarantool-patches
mailing list