[Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers

Kirill Yukhin kyukhin at tarantool.org
Fri May 14 10:56:58 MSK 2021


On 04 май 18:58, Cyrill Gorcunov wrote:
> We've been notified that if tarantool instance is running for
> long time slice the logger start to print weird lines such as
>  | main/-244760339/cartridge.failover.task I> Instance state changed
> where fiber's ID represented as a negative number. Eventually we
> discovered a few issues
>  - a bunch of say_x called with wrong specificators but compiler
>    simply ignored it
>  - fiber IDs are wrapping and this is inconvenient
>  - CFORMAT simply doesn't work
> In the series we fix all these issues. Note that using simplified
> form for unsigned arguments such as
> 	"%llu", (long long)(uint64_t)
> is pretty fine becase signed/unsiged values are counterpart of
> each other guaranteed by standart.
> issue https://github.com/tarantool/tarantool/issues/5846
> branch gorcunov/gh-5846-fid-name-3

I've checked your patch set into master.

Regards, Kirill Yukhin

More information about the Tarantool-patches mailing list