[Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers
v.shpilevoy at tarantool.org
Wed May 12 21:41:42 MSK 2021
On 11.05.2021 23:24, Cyrill Gorcunov wrote:
> On Wed, May 12, 2021 at 12:15:39AM +0300, Cyrill Gorcunov wrote:
>> On Tue, May 11, 2021 at 10:13:01PM +0200, Vladislav Shpilevoy wrote:
>>> Hi! Good job on the fixes, really!
>>> Although function lbox_fiber_statof() still uses lua_pushinteger():
>> Thanks a huge for catching it, Vlad. Here is an update. Squashed
>> to patch 1 "fiber: use uint64_t for fiber IDs" and force pushed.
> And one more addon (squashed) because 20 chars won't fit 8 byte
> unsiged together with "fiber: " prefix. Also I'm a bit worried of
> static int
> lbox_fiber_top_entry(struct fiber *f, void *cb_ctx)
> struct lua_State *L = (struct lua_State *) cb_ctx;
> --> lua_pushfstring(L, "%f/%s", (lua_Number)f->fid, f->name);
> why do we use float formate here at all?!
Because lua_pushfstring() does not support %llu.
More information about the Tarantool-patches