[Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs.
Sergey Kaplun
skaplun at tarantool.org
Tue May 11 14:02:28 MSK 2021
Hi, Igor!
Thanks for the patch! LGTM!
On 11.05.21, Igor Munkin wrote:
> From: Mike Pall <mike>
Side note: I am a little bit confused by this line (I thought that it is
a part of the commit message). May be it is better to drop it or to
write like:
| # From: Mike Pall <mike>
>
> (cherry picked from commit 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203)
>
> After Apple released Macs working on ARM64, the previous recipe in
> lj_arch.h for detecting various Apple platforms is not valid anymore.
> Fortunately, there is a system header (i.e. TargetConditionals.h),
> provided by SDK with the proper defines to be set. Starting from this
> patch, LuaJIT identifies Apple hosts via this header.
>
> Since testing machinery assumes that LuaJIT is built with JIT support
> being enabled unconditionally, a smoke test for it is also added
> alongside with this patch.
>
> Igor Munkin:
> * added the description and the test for the problem
> * backported the original patch to tarantool/luajit repo
>
> Part of tarantool/tarantool#5629
> Relates to tarantool/tarantool#5983
>
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---
<snipped>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list