[Tarantool-patches] [PATCH v3 09/10] wal: fix say_x format
Vladislav Shpilevoy
v.shpilevoy at tarantool.org
Mon May 10 21:40:32 MSK 2021
Good job on the patch!
> diff --git a/src/box/wal.c b/src/box/wal.c
> index 6468df884..fff530a38 100644
> --- a/src/box/wal.c
> +++ b/src/box/wal.c
> @@ -1009,13 +1009,14 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base,
> int64_t diff = (*row)->lsn - vclock_get(base, (*row)->replica_id);
> if (diff <= vclock_get(vclock_diff,
> (*row)->replica_id)) {
> + int64_t confirmed_lsn =
> + vclock_get(base, (*row)->replica_id) +
> + vclock_get(vclock_diff, (*row)->replica_id);
> say_crit("Attempt to write a broken LSN to WAL:"
> - " replica id: %d, confirmed lsn: %d,"
> - " new lsn %d", (*row)->replica_id,
> - vclock_get(base, (*row)->replica_id) +
> - vclock_get(vclock_diff,
> - (*row)->replica_id),
> - (*row)->lsn);
> + " replica id: %d, confirmed lsn: %lld,"
Replica ID should be %u, it is unsigned.
> + " new lsn %lld", (*row)->replica_id,
> + (long long)confirmed_lsn,
> + (long long)(*row)->lsn);
More information about the Tarantool-patches
mailing list