[Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers

Cyrill Gorcunov gorcunov at gmail.com
Tue May 4 18:58:09 MSK 2021


We've been notified that if tarantool instance is running for
long time slice the logger start to print weird lines such as

 | main/-244760339/cartridge.failover.task I> Instance state changed

where fiber's ID represented as a negative number. Eventually we
discovered a few issues

 - a bunch of say_x called with wrong specificators but compiler
   simply ignored it
 - fiber IDs are wrapping and this is inconvenient
 - CFORMAT simply doesn't work

In the series we fix all these issues. Note that using simplified
form for unsigned arguments such as

	"%llu", (long long)(uint64_t)

is pretty fine becase signed/unsiged values are counterpart of
each other guaranteed by standart.

issue https://github.com/tarantool/tarantool/issues/5846
branch gorcunov/gh-5846-fid-name-3

Cyrill Gorcunov (10):
  fiber: use uint64_t for fiber IDs
  popen: fix say_x format arguments
  raft: fix say_x arguments
  box/error: fix argument for CustomError
  xlog: fix say_x format
  box/vynil: fix say_x format
  txn: fix say_x format
  limbo: fix say_x format
  wal: fix say_x format
  say: fix CFORMAT specification

 changelogs/unreleased/gh-5846-cformat.md  | 12 +++++++++
 changelogs/unreleased/gh-5846-fiber-id.md |  4 +++
 src/box/error.cc                          |  2 +-
 src/box/txn.c                             |  3 ++-
 src/box/txn_limbo.c                       |  2 +-
 src/box/vy_scheduler.c                    |  2 +-
 src/box/wal.c                             | 17 ++++++------
 src/box/xlog.c                            |  4 +--
 src/lib/core/fiber.c                      | 30 ++++++++++-----------
 src/lib/core/fiber.h                      |  8 +++---
 src/lib/core/popen.c                      |  4 +--
 src/lib/core/say.c                        |  8 +++---
 src/lib/core/say.h                        |  2 +-
 src/lib/raft/raft.c                       |  5 ++--
 src/lua/fiber.c                           | 33 ++++++++++++-----------
 15 files changed, 79 insertions(+), 57 deletions(-)
 create mode 100644 changelogs/unreleased/gh-5846-cformat.md
 create mode 100644 changelogs/unreleased/gh-5846-fiber-id.md


base-commit: 4500547d7a177c0b49bff35c922286b4f21c8719
-- 
2.30.2



More information about the Tarantool-patches mailing list