[Tarantool-patches] [PATCH v2 luajit 24/30] test: disable PUC Lua test for non-asci identifier

Igor Munkin imun at tarantool.org
Wed Mar 31 22:23:58 MSK 2021


Sergey,

Thanks for the patch! LGTM, except the nits below.

On 26.03.21, Sergey Kaplun wrote:
> LuaJIT does not avoid to use non-alphanumeric symbols as identifiers,

Typo: s/avoid to use/forbid using/.

> unlike Lua does.
> 
> This patch disables test that expects an error during parsing variable

Typo: s/disables test/disables the test/.
Typo: s/parsing variable/parsing the variable name/.

> contains octal \255 as the first char in a variable name.

Typo: s/contains/containing/.

> 
> Part of tarantool/tarantool#5845
> Part of tarantool/tarantool#4473
> ---
>  test/PUC-Lua-5.1-tests/errors.lua | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/test/PUC-Lua-5.1-tests/errors.lua b/test/PUC-Lua-5.1-tests/errors.lua
> index af776a7..028224c 100644
> --- a/test/PUC-Lua-5.1-tests/errors.lua
> +++ b/test/PUC-Lua-5.1-tests/errors.lua
> @@ -202,7 +202,11 @@ checksyntax("[[a]]", "", "[[a]]", 1)
>  checksyntax("'aa'", "", "'aa'", 1)
>  
>  -- test 255 as first char in a chunk
> -checksyntax("\255a = 1", "", "\255", 1)
> +-- LuaJIT does not avoid to use non-alphanumeric symbols

Typo: s/avoid to use/forbid using/.

> +-- as identifiers, unlike Lua does.
> +-- For more details see <src/lj_char.c> and <src/lj_lex.c>.
> +-- LuaJIT: Test is disabled for LuaJIT.
> +-- checksyntax("\255a = 1", "", "\255", 1)
>  
>  doit('I = loadstring("a=9+"); a=3')
>  assert(a==3 and I == nil)
> -- 
> 2.31.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list