[Tarantool-patches] [PATCH v2 luajit 18/30] test: replace math.mod to math.fmod for Lua tests

[Igor Munkin]

Sergey,

Thanks for the patch! LGTM, except the nits below.

There is a typo in commit subject:
s/replace math.mod to math.fmod/replace math.mod with math.fmod/.

On 26.03.21, Sergey Kaplun wrote:
> In Lua 5.1 math.mod() is renamed to math.fmod() if build Lua 5.1 without

Typo: s/if build Lua 5.1/if Lua 5.1 is built/ or
      s/if build Lua 5.1/if one build Lua 5.1/.

> flag `-DLUA_COMPAT_MOD`.

Typo: s/flag `-DLUA_COMPAT_MOD`/`-DLUA_COMPAT_MOD` flag/.

> LuaJIT has math.fmod() instead old-style math.mod() built-in.

Typo: s/instead old-style/instead of old-style/.

You can also mention the commit[1] where this is done.

> 
> This patch replaces usage of math.mod with new-style math.fmod
> in the following files:
> * closure.lua
> * constructs.lua
> * math.lua
> * nextvar.lua
> 
> Closes tarantool/tarantool#5711

As we discussed before: s/Closes/Resolves/.

> Part of tarantool/tarantool#5845
> Part of tarantool/tarantool#4473
> ---
>  test/PUC-Lua-5.1-tests/closure.lua    | 3 ++-
>  test/PUC-Lua-5.1-tests/constructs.lua | 6 ++++--
>  test/PUC-Lua-5.1-tests/math.lua       | 3 ++-
>  test/PUC-Lua-5.1-tests/nextvar.lua    | 3 ++-
>  4 files changed, 10 insertions(+), 5 deletions(-)

Typo: s/instead old-style/instead of old-style/g in all chunks.

> 

<snipped>

> -- 
> 2.31.0
> 

[1]: https://github.com/tarantool/luajit/commit/de5568e

-- 
Best regards,
IM