[Tarantool-patches] [PATCH v4 53/53] sql: introduce mem_get_length()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Mar 30 02:09:21 MSK 2021


Thanks for the patch!

> diff --git a/src/box/sql/func.c b/src/box/sql/func.c
> index 199f3abef..6687fca3c 100644
> --- a/src/box/sql/func.c
> +++ b/src/box/sql/func.c
> @@ -967,7 +968,7 @@ case_type##ICUFunc(sql_context *context, int argc, sql_value **argv)   \
>  		return;                                                        \
>  	}                                                                      \
>  	z2 = mem_get_str(argv[0]);                                            \
> -	n = sql_value_bytes(argv[0]);                                      \
> +	n = mem_get_length(argv[0]);                                      \

All these \ were aligned before your patchset. Please, keep it straight.

>  	/*                                                                     \
>  	 * Verify that the call to _bytes()                                    \
>  	 * does not invalidate the _text() pointer.                            \


More information about the Tarantool-patches mailing list