[Tarantool-patches] [PATCH v4 27/53] sql: refactor mem_set_double()

[Vladislav Shpilevoy]

Thanks for the patch!

See 2 comments below.

On 23.03.2021 10:35, Mergen Imeev via Tarantool-patches wrote:
> This patch introduces mem_set_double(). Function mem_set_double()
> clears MEM and sets it to given unsigned value.

1. It is not about unsigned.

> Part of #5818
> ---
> diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h
> index bf3690b7c..49b4e4b1a 100644
> --- a/src/box/sql/mem.h
> +++ b/src/box/sql/mem.h
> @@ -419,10 +422,6 @@ int sqlVdbeMemClearAndResize(struct Mem * pMem, int n);
>  void
>  mem_set_ptr(struct Mem *mem, void *ptr);
>  
> -/** Set double value and MEM_Real flag. */
> -void
> -mem_set_double(struct Mem *mem, double value);

2. Why do you move these functions and their definitions? What was
wrong with keeping them in place?

> -
>  int
>  sqlVdbeMemSetStr(struct Mem *, const char *, int, u8, void (*)(void *));
>  void
>