[Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly
Igor Munkin
imun at tarantool.org
Mon Mar 29 22:11:26 MSK 2021
Sergey,
On 29.03.21, Sergey Kaplun wrote:
> Igor,
>
<snipped>
>
> Thanks! I like it, exept some typos:
>
> >
> > | ##feature/luajit
> > |
> > | * Make LuaJIT memory profiler parser output more user-friendly (gh-5811).
> > | Now the source line definition where the event occurs is much clearer:
> > | only source file name and allocation-related line are presented,
>
> Typo? s/are presented/is presented/
No, since both *are* presented.
>
> > | function definition line number is omitted. Moreover, event-related
>
> Typo: /function definition line number/the function definition line number/.
Fixed.
>
> > | statistics are indicated with units.
> > | **Breaking change**: Line info of the line function definition is
> > | saved in symbol info table by field `linedefined` now and field `name`
> > | is renamed to `source` with the respect to Lua Debug API.
>
> Typo: s/to Lua Debug/to the Lua Debug/
Fixed.
>
<snipped>
>
> --
> Best regards,
> Sergey Kaplun
--
Best regards,
IM
More information about the Tarantool-patches
mailing list