[Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly
Sergey Kaplun
skaplun at tarantool.org
Mon Mar 29 16:00:57 MSK 2021
Igor,
On 29.03.21, Igor Munkin wrote:
> Sergey,
>
> Thanks for the fixes! I'll push it to the trunk as soon as Sergos gives
> his LGTM.
>
> On 29.03.21, Sergey Kaplun wrote:
> > Igor,
> >
> > Thanks for the review!
> >
>
> <snipped>
>
> >
> > Missed ChangeLog entry, feel free to change it at your pleasure:
>
> Great, thanks! I propose the following wording:
Thanks! I like it, exept some typos:
>
> | ##feature/luajit
> |
> | * Make LuaJIT memory profiler parser output more user-friendly (gh-5811).
> | Now the source line definition where the event occurs is much clearer:
> | only source file name and allocation-related line are presented,
Typo? s/are presented/is presented/
> | function definition line number is omitted. Moreover, event-related
Typo: /function definition line number/the function definition line number/.
> | statistics are indicated with units.
> | **Breaking change**: Line info of the line function definition is
> | saved in symbol info table by field `linedefined` now and field `name`
> | is renamed to `source` with the respect to Lua Debug API.
Typo: s/to Lua Debug/to the Lua Debug/
>
<snipped>
> > > > --
> > > > 2.31.0
> > > >
> > >
> > > --
> > > Best regards,
> > > IM
> >
> > --
> > Best regards,
> > Sergey Kaplun
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list