[Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly

[Sergey Kaplun]

Profiler parser output looks like the following:
| ALLOCATIONS
| @true_memleak.lua:6, line 9: 3	144	0
| @true_memleak.lua:6, line 8: 2	41	0

Line of function definition is confusing for users and looks redundant.
Also, these "magic numbers" may shock users.

This patch removes lines of function definitions from the output.
Info about the line function definition is saved inside symbol info
table by field `defined` (it can be used later for a user's custom
parser). Moreover, explanatory words and signs are added to numbers
for more verbose output.

After the patch, profiler parser output looks like the following:
| ALLOCATIONS
| @true_memleak.lua:9: 3 events	+144 bytes	-0 bytes
| @true_memleak.lua:8: 2 events	+41 bytes	-0 bytes

Resolves tarantool/tarantool#5811
Part of tarantool/tarantool#5657
---
Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5811-user-friendly-memprof
Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5811-user-friendly-memprof
Issues:
* https://github.com/tarantool/tarantool/issues/5811
* https://github.com/tarantool/tarantool/issues/5657

 test/tarantool-tests/misclib-memprof-lapi.test.lua | 4 +++-
 tools/memprof/humanize.lua                         | 2 +-
 tools/utils/symtab.lua                             | 5 +++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua
index 1c36c8ab..6aa33198 100644
--- a/test/tarantool-tests/misclib-memprof-lapi.test.lua
+++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua
@@ -56,7 +56,9 @@ local function fill_ev_type(events, symbols, event_type)
     }
     elseif symbols[addr] then
       ev_type[event.loc.line] = {
-        name = symbols[addr].name,
+        name = string.format(
+          "%s:%d", symbols[addr].name, symbols[addr].defined
+        ),
         num = event.num,
       }
     end
diff --git a/tools/memprof/humanize.lua b/tools/memprof/humanize.lua
index 109a39db..2d5814c6 100644
--- a/tools/memprof/humanize.lua
+++ b/tools/memprof/humanize.lua
@@ -20,7 +20,7 @@ function M.render(events, symbols)
 
   for i = 1, #ids do
     local event = events[ids[i]]
-    print(string.format("%s: %d\t%d\t%d",
+    print(string.format("%s: %d events\t+%d bytes\t-%d bytes",
       symtab.demangle(symbols, event.loc),
       event.num,
       event.alloc,
diff --git a/tools/utils/symtab.lua b/tools/utils/symtab.lua
index 03aadbd5..6cfa1065 100644
--- a/tools/utils/symtab.lua
+++ b/tools/utils/symtab.lua
@@ -25,7 +25,8 @@ local function parse_sym_lfunc(reader, symtab)
   local sym_line = reader:read_uleb128()
 
   symtab[sym_addr] = {
-    name = string_format("%s:%d", sym_chunk, sym_line),
+    name = sym_chunk,
+    defined = sym_line,
   }
 end
 
@@ -80,7 +81,7 @@ function M.demangle(symtab, loc)
   end
 
   if symtab[addr] then
-    return string_format("%s, line %d", symtab[addr].name, loc.line)
+    return string_format("%s:%d", symtab[addr].name, loc.line)
   end
 
   return string_format("CFUNC %#x", addr)
-- 
2.31.0