[Tarantool-patches] [PATCH v2 luajit 26/30] test: disable tests with multiple -l options

Sergey Ostanevich sergos at tarantool.org
Fri Mar 26 18:56:38 MSK 2021


LGTM.
Sergos 

> On 26 Mar 2021, at 10:43, Sergey Kaplun <skaplun at tarantool.org> wrote:
> 
> Tarantool may crash when -e or -l option and their argument are not
> separated by space.
> 
> This patch disables tests leading to crash.
> 
> Relates to tarantool/tarantool#5747
> Part of tarantool/tarantool#5845
> Part of tarantool/tarantool#4473
> ---
> test/PUC-Lua-5.1-tests/main.lua | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/test/PUC-Lua-5.1-tests/main.lua b/test/PUC-Lua-5.1-tests/main.lua
> index cf6d533..73bff52 100644
> --- a/test/PUC-Lua-5.1-tests/main.lua
> +++ b/test/PUC-Lua-5.1-tests/main.lua
> @@ -52,8 +52,12 @@ end
> -- test 2 files
> prepfile("print(1); a=2")
> prepfile("print(a)", otherprog)
> -RUN("lua -l %s -l%s -lstring -l io %s > %s", prog, otherprog, otherprog, out)
> -checkout("1\n2\n2\n")
> +-- FIXME: Tarantool may crash when -e or -l option and their
> +-- argument are not separated by space.
> +-- The test is disabled for the Tarantool binary.
> +-- See https://github.com/tarantool/tarantool/issues/5747.
> +-- RUN("lua -l %s -l%s -lstring -l io %s > %s", prog, otherprog, otherprog, out)
> +-- checkout("1\n2\n2\n")
> 
> -- LuaJIT: test file is adapted for LuaJIT's test system, see
> -- the comment near `progname` initialization.
> @@ -92,8 +96,12 @@ prepfile[[print(({...})[30])]]
> RUN("lua %s %s > %s", prog, string.rep(" a", 30), out)
> checkout("a\n")
> 
> -RUN([[lua "-eprint(1)" -ea=3 -e "print(a)" > %s]], out)
> -checkout("1\n3\n")
> +-- FIXME: Tarantool may crash when -e or -l option and their
> +-- argument are not separated by space.
> +-- The test is disabled for the Tarantool binary.
> +-- See https://github.com/tarantool/tarantool/issues/5747.
> +-- RUN([[lua "-eprint(1)" -ea=3 -e "print(a)" > %s]], out)
> +-- checkout("1\n3\n")
> 
> prepfile[[
>   print(
> -- 
> 2.31.0
> 



More information about the Tarantool-patches mailing list