[Tarantool-patches] [PATCH v4 1/3] gc/xlog: delay xlog cleanup until relays are subscribed

Cyrill Gorcunov gorcunov at gmail.com
Fri Mar 26 10:04:01 MSK 2021


On Fri, Mar 26, 2021 at 12:50:40AM +0100, Vladislav Shpilevoy wrote:
> > 
> >  | tarantool> box.cfg{wal_cleanup_delay = math.huge}
> >  | ---
> >  | - error: 'Incorrect value for option ''wal_cleanup_delay'': value must be finite and
> >  |     >= 0'
> >  | ...
> > 
> 
> You don't need to change it to finite if it works fine being infinite.
> I only wanted to have a test that it does not crash somewhere on that.
> 
> If it would crash, it would mean we would need to fix the other timeouts
> too. Otherwise your timeout still is inconsistent with them if you ban
> the literal infinity.

I personally think this is wrong to allow enter arbitrary values here
but won't insist, I'll drop this test.


More information about the Tarantool-patches mailing list