[Tarantool-patches] [PATCH v3 0/3] gc/xlog: delay xlog cleanup until relays are subscribed

Cyrill Gorcunov gorcunov at gmail.com
Tue Mar 23 22:07:53 MSK 2021

On Tue, Mar 23, 2021 at 09:33:45PM +0300, Cyrill Gorcunov wrote:
> > 
> > issue https://github.com/tarantool/tarantool/issues/5806
> > branch gorcunov/gh-5806-xlog-gc-3
> I just noticed that with this change the test replication/replica_rejoin.test.lua
> started to fail. Investigating. I think it is due to default timeout.

As far as I understand this is because our wal_cleanup_delay is not zero by default
and doesn't allow to purge old xlog files until relays are connected back. In turn
the test does exactly the reverse -- it expects main node to purge old xlogs.

Actully I'm not sure what to do -- we can tune up the test case (ie explicitly set
wal_cleanup_delay to 0) and it start passing but this looks like some backward
compatiblity breakage: can't there be someone who relies to old behaviour? If so
we should set wal_cleanup_delay to 0 by default, no?


More information about the Tarantool-patches mailing list