[Tarantool-patches] [PATCH 02/16] test: don't use IBUF_SHARED in the tests

Cyrill Gorcunov gorcunov at gmail.com
Mon Mar 22 10:35:17 MSK 2021


On Sat, Mar 20, 2021 at 01:42:39AM +0100, Vladislav Shpilevoy wrote:
> In msgpack test it is used only to check that 'struct ibuf *' can
> be passed to encode() functions. But soon IBUF_SHARED will be
> deleted, and its alternative won't be yield-tolerant. This means
> it can't be used in this test. There are yields between the buffer
> usages.
> 
> In varbinary test it is used in a too complicated way to be able
> to put it back normally. And otherwise its usage does not make
> much sense - without put() it is going to be created from the
> scratch on non-first usage until a yield.
> 
> In the module_api test it is used to check if some function works
> with 'struct ibuf *'. Can be done without IBUF_SHARED.

Ack


More information about the Tarantool-patches mailing list