[Tarantool-patches] [PATCH v8] base64: fix decoder output buffer overrun (reads)

Kirill Yukhin kyukhin at tarantool.org
Fri Mar 19 18:47:54 MSK 2021


Hello,

On 09 мар 12:59, Sergey Nikiforov via Tarantool-patches wrote:
> Was caught by base64 test with enabled ASAN.
> 
> It also caused data corruption - garbage instead of "extra bits" was
> saved into state->result if there was no space in output buffer.
> 
> Decode state removed along with helper functions.
> 
> Added test for "zero-sized output buffer" case.
> 
> Fixes: #3069

I think we should stop it.

LGTM.

I've checked your patch into 1.10, 2.6, 2.7 and master.

--
Regards, Kirill Yukhin


More information about the Tarantool-patches mailing list