[Tarantool-patches] [PATCH luajit 3/6] test: disable 305-utf8 of lua-Harness suite

Igor Munkin imun at tarantool.org
Mon Mar 15 15:45:19 MSK 2021


Thanks for the patch, but it is excess. The issue does not relates to
utf8.* functions per se (the are none of them provided by LuaJIT), but
rather the way UTF-8 support is checked in the test: if there is "falsy"
value stored in <utf8> global, then test simply checks that UTF-8
support is not expected considering to the loaded profile. Hence, simply
make <utf8> nil in test/luajit-init-test.lua (you can also "unload" it
from package.loaded, but this is not obliged, since utf8 is not
required in the test) and leave the test itself unmasked.

On 12.03.21, Sergey Kaplun wrote:
> This patch disables 305-utf8.t from the lua-Harness test suite, because
> the built-in utf8 module in Tarantool does not work as expected in the
> test.
> Partially the problem mentioned in tarantool/tarantool#5241.
> Part of tarantool/tarantool#5844
> Part of tarantool/tarantool#4473
> ---
>  test/lua-Harness-tests/{305-utf8.t => 305-utf8.t.disabled} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename test/lua-Harness-tests/{305-utf8.t => 305-utf8.t.disabled} (100%)
> diff --git a/test/lua-Harness-tests/305-utf8.t b/test/lua-Harness-tests/305-utf8.t.disabled
> similarity index 100%
> rename from test/lua-Harness-tests/305-utf8.t
> rename to test/lua-Harness-tests/305-utf8.t.disabled
> -- 
> 2.28.0

Best regards,

More information about the Tarantool-patches mailing list