[Tarantool-patches] [PATCH v9 2/2] relay: provide information about downstream lag

[Vladislav Shpilevoy]

Thanks for the fixes!

On 21.06.2021 18:17, Cyrill Gorcunov wrote:
> On Sun, Jun 20, 2021 at 04:37:21PM +0200, Vladislav Shpilevoy wrote:
>> Hi! Thanks for the patch!
>>
>> The test fails when I run it multiple times:
>>
>> [014] Test failed! Result content mismatch:
>> [014] --- replication/gh-5447-downstream-lag.result	Sun Jun 20 16:10:26 2021
>> [014] +++ var/rejects/replication/gh-5447-downstream-lag.reject	Sun Jun 20 16:33:01 2021
>> [014] @@ -37,7 +37,7 @@
>> [014]  -- Upon replica startup there is no ACKs to process.
>> [014]  assert(box.info.replication[replica_id].downstream.lag == 0)
>> [014]   | ---
>> [014] - | - true
>> [014] + | - error: assertion failed!
>>
>> See 4 comments below.
> 
> Vlad, here is an update, I force pushed it into the same branch.
> I'll fix the error injection nit. Could you please retry the
> test to run simultaneously (I did it locally with 200 tests
> but it didn't trigger anything). I rebased the series on top
> of master.

Strangely, I couldn't reproduce it again. Neither with the old
version, nor with the updated one.

The fixes look good. Please, squash, and fix the error injection
comment.