[Tarantool-patches] [PATCH v9 0/1] applier: filter incoming synchro packets via transaction initiator

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Jun 20 17:50:10 MSK 2021


Thanks for the fixes!

>>>>> +-- Make the master to be RAFT leader, this drops connection
>>>>> +-- to the replica2.
>>>>
>>>> 3. There was no connection to replica2 from master.
>>>>
>>>
>>> I'll update the comment, thanks! (actually replica2
>>> connected to the master initialy and this is full
>>> duplex connection which we close on reconfig, that's
>>> what I meant saying "dropping" connection, but this
>>> seems to be confusing).
>>
>> In the comment you said that this reconfig
>> drops the connection. But it still does not, even in
>> the updated definition above.
>>
>> You dropped this connection a few lines before this
>> comment.
> 
> Vlad, here is an update, does it look better?

It looks better, but why did you ignore my first comment?
I remind it here:

	Maybe better rename it to gh-6035-election-filter. Because otherwise
	this test is not included when I run `python test-run.py election`. And I
	do that quite often when make a patch which affects election only.


More information about the Tarantool-patches mailing list