[Tarantool-patches] [PATCH] build: fix debug flags for LuaJIT assertions

[Igor Munkin]

Sergey,

Thanks for the patch! Please consider the nits below. Otherwise, LGTM.

On 02.06.21, Sergey Kaplun wrote:
> This patch fixes inaccuracy in Tarantool build configuration introduced
> by commit 07c83aa ('build: adjust

Typo: Please use the full hash.

> LuaJIT build system'). That patch sets LUAJIT_USE_ASSERT and
> LUAJIT_USE_APICHECK options for Debug build instead LUA_USE_ASSERT and

Typo: s/instead LUA_USE_ASSERT/instead of LUA_USE_ASSERT/.

> LUA_USE_APICHECK correspondingly. This patch fixes these typos.

Minor: s/correspondingly/respectively/.

> 
> Follows up #4862
> ---
> 
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/tarantool-debug-fix
> 
> 
> Also, LUAJIT_USE_ASAN -- is set, but LuaJIT checks for ENABLE_ASAN as
> is with corresponding FIXME to implement ASAN correctly. But it
> looks like it should be done in a separate patch by enabling all LuaJIT
> build flags, see list of options here [1].

BTW, we have a separate issue for enabling ASAN in LuaJIT[1].

> 
> [1]: https://lists.tarantool.org/tarantool-patches/20210211192336.GC9361@root/
> 
>  cmake/luajit.cmake | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

<snipped>

>  
> -- 
> 2.31.0
> 

[1]: https://github.com/tarantool/tarantool/issues/5878

-- 
Best regards,
IM