[Tarantool-patches] [PATCH v8 0/2] relay: provide downstream lag information

[Vladislav Shpilevoy]

Hi! Thanks for the patchset!

Please, provide branch and issue links next time.
https://github.com/tarantool/tarantool/wiki/Code-review-procedure#sending-the-patch

I assume your branch is gorcunov/gh-5447-relay-lag-8.

It seems after your changes some tests start failing. Looks
like you didn't clear artifacts of your new test.
https://github.com/tarantool/tarantool/runs/2765786321

On 07.06.2021 17:55, Cyrill Gorcunov wrote:
> Guys, take a look once time permit. Previous version is here
> 
> https://lists.tarantool.org/tarantool-patches/20210506214132.533913-1-gorcunov@gmail.com/
> 
> I still think we might need some general statistics engine because this
> lag rather common data and we could move other "last" things like last_row_time
> there but since I didn't get approve on the idea I keep the timestamp
> in replica structure.

If you are talking about your perf metrics engine which we tried to
design for replication, it was approved. The problem is that there was
no a really good design on how should it look and work.