[Tarantool-patches] [PATCH vshard 1/1] recovery: relax recovery messages verbosity

Oleg Babin olegrok at tarantool.org
Thu Jun 3 16:22:52 MSK 2021


Thanks for changes and answers. LGTM. Single nit below.

On 03.06.2021 15:55, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
>
>>> diff --git a/vshard/storage/init.lua b/vshard/storage/init.lua
>>> index 7045d91..8a019fa 100644
>>> --- a/vshard/storage/init.lua
>>> +++ b/vshard/storage/init.lua
>>> @@ -736,21 +736,25 @@ local function recovery_step_by_type(type)
>>>        local is_empty = true
>> To be honest I don't completely understand what "is_empty" means.
> It means the recovery step is empty - didn't find anything to
> recover.
>
> I use it so as not to log 'Starting ... buckets recovery step' on
> each call of recovery_step_by_type() - would be too many useless
> logs.


Ok, thanks for your answers. Probably, it's better to rename "is_empty" 
to "step_is_empty".

It's ok if you'll answer "no", since it's refactoring.



More information about the Tarantool-patches mailing list