[Tarantool-patches] [PATCH luajit 2/4] test: add skipcond on architectures for memprof

[Sergey Ostanevich]

Hi!

Thanks for the patch!
Just one fixup is needed.

Sergos

> On 24 May 2021, at 16:27, Sergey Kaplun <skaplun at tarantool.org> wrote:
> 
> Memprof's tests fail for architectures different from x86 and x64,
> because memprof is not yet implemented for them.
> 
> This patch adds skip condition to corresponding test.
> ---
> test/tarantool-tests/misclib-memprof-lapi.test.lua | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua
> index b4d66509..4df9cfd8 100644
> --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua
> +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua
> @@ -1,3 +1,9 @@
> +-- Memprof is implemented only for x86 and x64 architectures.
                             ^^^^ ——>                          ^
> +require("utils").skipcond(
> +  jit.arch ~= "x86" or jit.arch ~= "x64",

I believe you overcomplicated the condition so it’ll skip even for
mentioned archs

tarantool> x='x86'
---
...

tarantool> x~='x86' or x~='x64'
---
- true
...



> +  jit.arch.." architecture is NIY for memprof"
> +)
> +
> local tap = require("tap")
> 
> local test = tap.test("misc-memprof-lapi")
> -- 
> 2.31.0
>