[Tarantool-patches] [PATCH 3/3] test: replication/status -- fetch downstream lag field

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Jan 31 20:46:03 MSK 2021


Thanks for the patch!

> diff --git a/test/replication/status.result b/test/replication/status.result
> index a8c515dbb..e59694730 100644
> --- a/test/replication/status.result
> +++ b/test/replication/status.result
> @@ -186,6 +186,14 @@ test_run:wait_cond(function()                    \
>  ---
>  - true
>  ...
> +-- once replication vclock is reached there
> +-- should be non infinity downstream lag, set
> +-- it to some sane value but not short since
> +-- there might be network lags on a low level

At least in the tests try to start sentences with a capital
letter and end them with a period. Also for tests related to a
ticket we add 'gh-####: ` to the beginning of the comment.

> +replica.downstream.lag ~= nil and replica.downstream.lag < 60
> +---
> +- true
> +...


More information about the Tarantool-patches mailing list