[Tarantool-patches] [PATCH 3/6] test/unit: snap_quorum_delay -- stop using txn_set_flag

Cyrill Gorcunov gorcunov at gmail.com
Sun Jan 31 13:40:42 MSK 2021

On Sat, Jan 30, 2021 at 08:17:57PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> Ok, I assume it is fine to drop these functions one by one, even
> though it leaves the flags usage inconsistent between the commits.

The flags usage remains consistent in terms of operations.

> But why the hell did you split even one function clearance into 2
> commits? Why couldn't this commit be a part of the previous commit?

Because I don't know down to which branch the patches gonna be merged.
IOW, txn flags are appeared a way earlier than syncrho tests. Thus
one can simply skip this patch when backporting the commits.

> Any why couldn't you delete the unused txn_..._flag() helpers along
> with their usage?

This is better done in one commit when everything is ready. I prefer
this way, though there is no strict rule and if you promote immediate
function zapping then I can update the series.

More information about the Tarantool-patches mailing list