[Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 in test/sql-tap

Sergey Bronnikov sergeyb at tarantool.org
Sat Jan 30 00:50:19 MSK 2021


On 29.01.2021 19:23, Sergey Bronnikov wrote:
> Thanks for review!
>
> On 24.01.2021 20:36, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> See 3 comments below.
>>
>> On 21.01.2021 13:50, sergeyb at tarantool.org wrote:
>>> From: Sergey Bronnikov <sergeyb at tarantool.org>
>>>
>>> W612 (A line contains trailing whitespace)
>>> W613 (Trailing whitespace in a string)
>>> W614 (Trailing whitespace in a comment)
>>>
>>> Note: changes were made automatically in vim with regexp "%s/\s\+$//e".
>>>
>>> Part of #5464
>>> ---
>>> diff --git a/test/sql-tap/analyzeD.test.lua 
>>> b/test/sql-tap/analyzeD.test.lua
>>> index 12722a3d4..e0426b974 100755
>>> --- a/test/sql-tap/analyzeD.test.lua
>>> +++ b/test/sql-tap/analyzeD.test.lua
>>> @@ -54,7 +54,7 @@ test:do_test(
>>>               ANALYZE;
>>>           ]])
>>>       end, {
>>> -            -- <1.1>
>>> +            -- <1.1>
>> 1. Git highligts this line with red. I assume here is an inconsistency
>> between tabs and spaces. But it does not matter as these comments can
>> be dropped. They are useless artifacts of TCL -> Lua translation.
>
> Removed
>
<snipped>


Some testcases in test/sql-tap/tkt3935.test.lua and 
test/sql-tap/join.test.lua fails when trailing whitespace removed in SQL 
command line,

so expected output line has been updated too where it was required.



More information about the Tarantool-patches mailing list