[Tarantool-patches] [PATCH v1] static-build: use hashes of downloaded files

[Alexander Turenko]

On Wed, Jan 27, 2021 at 07:37:01PM +0300, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
> 
> Using hashes in ExternalProject_Add() [1] allows to avoid extra
> downloads on rebuilds.
> 
> 1. https://cmake.org/cmake/help/latest/module/ExternalProject.html
> 
> Closes #5761

I don't know this machinery much, but it looks worthful and I don't see
any downsides.

LGTM.

> diff --git a/static-build/CMakeLists.txt b/static-build/CMakeLists.txt
> index 9a2f85052..39cb321d0 100644
> --- a/static-build/CMakeLists.txt
> +++ b/static-build/CMakeLists.txt
> @@ -40,6 +40,7 @@ endif()
>  #
>  ExternalProject_Add(openssl
>      URL https://www.openssl.org/source/openssl-${OPENSSL_VERSION}.tar.gz
> +    URL_MD5 3f486f2f4435ef14b81814dbbc7b48bb

Nit: I would place certain hash values near to the versions block to
don't spread dependent information and descrease probability to forget
to update a checksum together with a version.