[Tarantool-patches] [PATCH v8 14/14] luacheck: add issues for suppressed warnings

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Jan 24 20:37:50 MSK 2021


Thanks for the patch!

On 21.01.2021 13:50, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
> 
> Closes #5464
> ---
>  .luacheckrc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index a798ca6f8..597988367 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -52,8 +52,10 @@ exclude_files = {
>  files["test/sql-tap/**/*.lua"] = {
>      ignore = {
>          -- A line consists of nothing but whitespace.
> +        -- https://github.com/tarantool/tarantool/issues/5739

Why can't you fix this one now? Is it so hard that it is
worth adding a special issue for it? Doesn't the whole work
consists of removing a bunch of empty lines or whitespaces
from these lines?

>          "611",
>          -- Line is too long.
> +        -- https://github.com/tarantool/tarantool/issues/5181
>          "631"
>      }
>  }
> 


More information about the Tarantool-patches mailing list