[Tarantool-patches] [PATCH v1 4/4] test: enable disabled testcases back
Leonid Vasiliev
lvasiliev at tarantool.org
Thu Jan 14 12:10:14 MSK 2021
Hi! Thank you for the patch.
LGTM.
On 13.01.2021 11:48, sergeyb at tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb at tarantool.org>
>
> In a commit "httpc: temporary disable redirecting test case"
> (4cc6978ae7be7dc3785a52c064b07850582522de) a set of testcases
> has been disabled while the bug #4180 is open.
> Right now bug is closed so it is a time to enable testcases back.
> ---
> test/app-tap/http_client.test.lua | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/test/app-tap/http_client.test.lua b/test/app-tap/http_client.test.lua
> index 093af8fe4..aafad0004 100755
> --- a/test/app-tap/http_client.test.lua
> +++ b/test/app-tap/http_client.test.lua
> @@ -62,7 +62,7 @@ local function stop_server(test, server)
> end
>
> local function test_http_client(test, url, opts)
> - test:plan(11)
> + test:plan(12)
>
> -- gh-4136: confusing httpc usage error message
> local ok, err = pcall(client.request, client)
> @@ -85,9 +85,6 @@ local function test_http_client(test, url, opts)
> local r = client.request('GET', url, nil, opts)
> test:is(r.status, 200, 'request')
>
> - -- XXX: enable after resolving of gh-4180: httpc: redirects
> - -- are broken with libcurl-7.30 and older
> - --[[
> -- gh-4119: specify whether to follow 'Location' header
> test:test('gh-4119: follow location', function(test)
> test:plan(7)
> @@ -111,7 +108,6 @@ local function test_http_client(test, url, opts)
> test:is(r.body, 'redirecting', 'do not follow location: body')
> test:is(r.headers['location'], '/', 'do not follow location: header')
> end)
> - ]]--
> end
>
> --
>
More information about the Tarantool-patches
mailing list