[Tarantool-patches] [PATCH 0/4] Choose allocator mor memtx

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Sun Jan 10 16:55:39 MSK 2021

Hi! Thanks for the patchset!

I didn't review the code yet. Only the commit messages. But already
can give some comments.

On 29.12.2020 12:03, mechanik20051988 via Tarantool-patches wrote:
> Branch: https://github.com/tarantool/tarantool/tree/mechanik20051988/gh-5419-choose-allocator-for-memtx-cpp-14
>         (Do not pay attention to the number 14 in the branch header)
> Issue: https://github.com/tarantool/tarantool/issues/5419
> Pull request: https://github.com/tarantool/tarantool/pull/5670
> About patches:
> 	1. First patch add performance test for memtx allocator. You can copy perf folder 
> 	to master branch and compare performance.
> 	2. Second patch convert some *.c files to *.cc files. 
> 	   This is the preparation for the patch with allocator choise
> 	3. Third patch implement api for allocator choise
> 	4. Fourth patch add system allocator based on malloc and free
> This is a completely redesigned patch, however I would like to provide answers 
> to some questions from the previous patch that may overlap
> 1. malloc_usable_size / malloc_size has different headers in different OS, so i use
>    TARGET_OS_*** to check this in source file not in CMakeLists
> 2. I test snapshot using checkpoint_interval=5 option, several snapshots
>    are created during my test

And I said in private that it not only makes the test run at least 5 seconds,
which is way too long. But also is not any different from calling box.snapshot()
manually. Please, use box.snapshot().

More information about the Tarantool-patches mailing list