[Tarantool-patches] [PATCH v2 09/10] wal: fix say_x format

Cyrill Gorcunov gorcunov at gmail.com
Thu Feb 25 10:52:19 MSK 2021


On Wed, Feb 24, 2021 at 11:41:18PM +0100, Vladislav Shpilevoy wrote:
> >  		say_error("Aborting transaction %llu during "
> >  			  "cascading rollback",
> > -			  vclock_sum(&writer->vclock));
> > +			  (long long)vclock_sum(&writer->vclock));
> 
> Long long should use %lld, not %llu. I have no idea why is the format checker
> silent about this.

Because they are same in size and can be freely exchanged, io it is
up to you hot to interpret data inside formatter as signed or unsigned,
the cast must provide the _size_ of argument, not its sign.


More information about the Tarantool-patches mailing list