[Tarantool-patches] [PATCH v2 05/10] xlog: fix say_x format

[Vladislav Shpilevoy]

Thanks for the patch!

On 24.02.2021 16:36, Cyrill Gorcunov wrote:
> The string length specificator expects length as
> integer value.
> 
> Part-of #5846
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>  src/box/xlog.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/box/xlog.c b/src/box/xlog.c
> index 974f460be..40c07abf0 100644
> --- a/src/box/xlog.c
> +++ b/src/box/xlog.c
> @@ -314,8 +314,8 @@ xlog_meta_parse(struct xlog_meta *meta, const char **data,
>  			/*
>  			 * Unknown key
>  			 */
> -			say_warn("Unknown meta item: `%.*s'", key_end - key,
> -				 key);
> +			say_warn("Unknown meta item: `%.*s'",

The quotes around %s are inconsistent: `' instead of '' or ``. Lets
use ''. I know it was there before your patch, but lets fix it anyway,
considering it a part of the format.

> +				 (int)(key_end - key), key);
>  		}
>  	}
>  	*data = end + 1; /* skip the last trailing \n of \n\n sequence */
>