[Tarantool-patches] [PATCH v2 02/10] popen: fix say_x format arguments

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Feb 25 01:39:39 MSK 2021


Hi! Thanks for the patch!

On 24.02.2021 16:36, Cyrill Gorcunov wrote:
> Drop redundant "%s" from format.

Neither of the changes below are about dropping a redundant %s.
First one drops %p, second one replaces it with %d and fixes
size_t.

> Part-of #5846
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>
> ---
>  src/lib/core/popen.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c
> index 3b5fd1062..99a3d3cbd 100644
> --- a/src/lib/core/popen.c
> +++ b/src/lib/core/popen.c
> @@ -240,7 +240,7 @@ handle_new(struct popen_opts *opts)
>  static inline void
>  handle_free(struct popen_handle *handle)
>  {
> -	say_debug("popen: handle %p free %p", handle);
> +	say_debug("popen: handle free %p", handle);
>  	free(handle);
>  }
>  
> @@ -533,7 +533,7 @@ popen_shutdown(struct popen_handle *handle, unsigned int flags)
>  		if (handle->ios[idx].fd < 0)
>  			continue;
>  
> -		say_debug("popen: %d: shutdown idx [%s:%d] fd %s",
> +		say_debug("popen: %d: shutdown idx [%s:%zd] fd %d",
>  			  handle->pid, stdX_str(idx), idx,
>  			  handle->ios[idx].fd);
>  		coio_close_io(loop(), &handle->ios[idx]);
> 


More information about the Tarantool-patches mailing list