[Tarantool-patches] [PATCH vshard 05/11] util: introduce safe fiber_cond_wait()

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Thu Feb 25 00:48:11 MSK 2021


Thanks for the review!

On 24.02.2021 11:27, Oleg Babin wrote:
> Hi! Thanks for your patch. LGTM.
> 
> I see several usages of cond:wait() in code. Maybe after introducing this helper you could use it.
> 
> E.g. in "bucket_send_xc" function.

Yeah, I checked the existing usages, but it is fine as is
there.

In bucket_send_xc() it is ok to throw. This is why it is 'xc' -
'exception'. It is ok, because there are other ops which can
throw, and eventually I decided not to wrap them all into pcalls.

In global fibers I kept the normal waits, because its throw here
is fine. They don't have any finalization work to do after the waits.


More information about the Tarantool-patches mailing list