[Tarantool-patches] [PATCH v2 00/10] say: fix format strings

Cyrill Gorcunov gorcunov at gmail.com
Wed Feb 24 18:36:16 MSK 2021


When been fixing issue 5846 we've found that our
format specification test simply doesn't work. Lets
use proper formatting and turn it back on.

Guys, I split the series per-file for better review
and probably fixups if there will be a need. After
all committer may simply merge all them except the
first one.

issue https://github.com/tarantool/tarantool/issues/5846
branch gorcunov/gh-5846-fid-name-2

v2:
 - add changelog
 - revisit CFORMAT
 - fix all warnings covered so far

Cyrill Gorcunov (10):
  say: use unsigned  format for fiber()->fid
  popen: fix say_x format arguments
  raft: fix say_x arguments
  box/error: fix argument for CustomError
  xlog: fix say_x format
  box/vynil: fix say_x format
  txn: fix say_x format
  limbo: fix say_x format
  wal: fix say_x format
  say: fix CFORMAT specification

 changelogs/unreleased/fix-fiber-fid-log.md |  5 +++++
 src/box/error.cc                           |  2 +-
 src/box/txn.c                              |  3 ++-
 src/box/txn_limbo.c                        |  2 +-
 src/box/vy_scheduler.c                     |  2 +-
 src/box/wal.c                              | 15 ++++++++-------
 src/box/xlog.c                             |  4 ++--
 src/lib/core/popen.c                       |  4 ++--
 src/lib/core/say.c                         |  6 +++---
 src/lib/core/say.h                         |  2 +-
 src/lib/raft/raft.c                        |  5 +++--
 11 files changed, 29 insertions(+), 21 deletions(-)
 create mode 100644 changelogs/unreleased/fix-fiber-fid-log.md


base-commit: 6610bce9bf43a139043518cd76d3c0c81c981ce2
-- 
2.29.2



More information about the Tarantool-patches mailing list