[Tarantool-patches] [PATCH] txn: convert flags to explicit bitfield

[Vladislav Shpilevoy]

Hi! Thanks for the patch!

> @@ -535,7 +535,7 @@ txn_complete_fail(struct txn *txn)
>  		txn_rollback_one_stmt(txn, stmt);
>  	if (txn->engine != NULL)
>  		engine_rollback(txn->engine, txn);
> -	if (txn_has_flag(txn, TXN_HAS_TRIGGERS))
> +	if (txn->flags & TXN_HAS_TRIGGERS)

1. Did you do a self-review before sending this? Can you
tell yourself what is wrong here?


2. What was wrong with the idea of having the helpers
but operating on bitfields? And having has_flags() instead
of has_flag() to check presense of all specified flags +
clear_flags() to remove all specified flags.

I don't understand. I think we discussed it already 2 or 3
times and all seemed to agree?