[Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI
Sergey Kaplun
skaplun at tarantool.org
Mon Feb 15 19:29:16 MSK 2021
Hi, Igor!
Thanks for the patch!
LGTM, except a few nits below.
On 04.02.21, Igor Munkin wrote:
> This patch adds LuaJIT tests to every CI job type except the one for
> static build testing routine on OSX: there is no way to run LuaJIT tests
> for out of source build on OSX due to SIP[1].
>
> [1]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtections.html
>
> Follows up #4862
Nit: looks like 'Closes' not 'Follows up'.
Feel free to ignore.
>
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---
> .travis.mk | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
Nit: There is one general comment for the whole patch:
In my opinion, it is better to run `make LuaJIT-tests` **before**
Tarantool test suite. If LuaJIT is broken failed Tarantool tests
information is useless (Is it LuaJIT? Always has been.).
Feel free to ignore.
>
> diff --git a/.travis.mk b/.travis.mk
> index 50524007c..c2b79a4e5 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -134,6 +134,7 @@ build_debian: configure_debian
<snipped>
> + # FIXME: Hell with SIP on OSX: Tarantool (and also LuaJIT)
> + # is built out of sources, so the test located in the
> + # source directory fails to load the shared library built
> + # in the binary directory via dlopen(3).
> + # For more info proceed the link below:
Typo: s/info, proceed/info proceed/
> + # https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtections.html
> + # Do not run LuaJIT related tests for this built until the
> + # issue is not resolved.
> + #
> + # make -C ${PWD}/static-build/tarantool-prefix/src/tarantool-build LuaJIT-test
<snipped>
> --
> 2.25.0
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list