[Tarantool-patches] [PATCH 3/9] test: introduce a helper to wait for bucket GC

Oleg Babin olegrok at tarantool.org
Thu Feb 11 09:50:11 MSK 2021


Thanks for your answer. Yes, it's fine. LGTM.

On 11/02/2021 01:33, Vladislav Shpilevoy wrote:
> Thanks for the review!
>
> On 10.02.2021 09:57, Oleg Babin wrote:
>> Hi! Thanks for your patch! LGTM but I have one question.
>>
>> Maybe it's reasonable to add some timeout in this function?
>>
>> AFAIK test-run terminates tests after 120 seconds of inactivity it seems too long for such simple case.
>>
>> But anyway it's up to you.
> test_run:wait_cond() has default timeout 1 minute. I decided it
> is fine.


More information about the Tarantool-patches mailing list