[Tarantool-patches] [PATCH luajit 3/5] test: run LuaJIT tests via CMake
Timur Safin
tsafin at tarantool.org
Tue Feb 9 16:59:29 MSK 2021
LGTM.
Modulo my usual note about 2nd comment about cmake. But you may already has it
fixed in your branch till this moment...
: From: Igor Munkin <imun at tarantool.org>
: Subject: Re: [PATCH luajit 3/5] test: run LuaJIT tests via CMake
:
: > :
: > : Unfortunately... CMake is a crap and I can't fix it. Well, honestly I
: > : don't want to fix it. But you're right: I can fix all these comments
: > : (athough I don't really want to). I have no idea how to express this in
: > : a more neutral way, so I propose the following:
: > : 1. s/CMake is a crap/there is no convenient way to make it in CMake/g.
: > : 2. Leave everything else unchanged.
: >
: > Hmm, ok.
:
: Fixed, squashed, force-pushed to the branch. Diff is below:
Nice! Thank you! But there is 2nd one...
:
: >
: > :
: > : This is not only emotions. Such comments prevent one from unintentional
: > : refactoring of such fragile places with no failures and also from
: > : bothering the oldies with the questions kinda "dude, why is this done so
: > : badly". In other words, primarily I have left this for the history.
: > :
: > : If you're OK, then I'll fix the way described above.
: > :
: > : >
: > : > : + # Add the directory where the lib is built to the LUA_CPATH
: > : > : + # environment variable, so interpreter can find and load it.
: > : > : + # XXX: Here we see the other side of the coin. If one joins two
: > : > : + # strings with semicolon, the value automatically becomes the
: > : > : + # list. I have no idea what is wrong with this tool,
About this one ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
: > : > : + but I found
: > : > : + # a single working solution to make LUA_CPATH be a string via
: > : > : + # "escaping" the semicolon right in string interpolation.
: > : > : + set(LUA_CPATH
: > : > :
: > :
Regards,
Timur
More information about the Tarantool-patches
mailing list