[Tarantool-patches] [PATCH v1 00/10] Encapsulate MEM type changing and checking
Timur Safin
tsafin at tarantool.org
Tue Feb 9 12:36:03 MSK 2021
Thanks for this refactoring attempt, but could you (please, please)
make it (somehow magically) easier to review? I mean the part where
we extract something from here, wrap I as a function, and replace
with that function call ideally would be to put to the same patch -
for better observability. So we make it more visible that functionality
remains intact?
I know that is tricky in git, but possible after some massaging. (May
Be simply squash it to the single patch as a first approach?)
I've no much complains yet about particular cases - but there is
some objection about newly introduced static_alloc, please see in
other message.
Regards,
Timur
: From: imeevma at tarantool.org <imeevma at tarantool.org>
: Subject: [PATCH v1 00/10] Encapsulate MEM type changing and checking
:
: This patch-set encapsulates type changing and checking for MEM. This is done
: to
: make easier for us to introduce new rules for implicit and explicit type
: casting
: and new types in SQL.
:
: https://github.com/tarantool/tarantool/issues/4470
: https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-encapsule-type-
: setting-v3
:
:
: Mergen Imeev (10):
: sql: introduce mem_set_*() functions
: sql: Initialize MEM in sqlVdbeAllocUnpackedRecord()
: sql: introduce mem_is_*() functions
: sql: introduce mem_convert_to_binary()
: sql: refactor vdbesort.c
: sql: refactor sql/func.c
: sql: refactor vdbetrace.c
: sql: refactor vdbeapi.c
: sql: refactor vdbeaux.c
: sql: refactor vdbe.c
:
: src/box/sql/func.c | 2 +-
: src/box/sql/vdbe.c | 453 ++++++++++++++++++----------------------
: src/box/sql/vdbeInt.h | 204 ++++++++++++++++++
: src/box/sql/vdbeapi.c | 53 ++---
: src/box/sql/vdbeaux.c | 268 +++++++++++-------------
: src/box/sql/vdbemem.c | 116 ++++++++++
: src/box/sql/vdbesort.c | 9 +-
: src/box/sql/vdbetrace.c | 12 +-
: 8 files changed, 674 insertions(+), 443 deletions(-)
:
: --
: 2.25.1
More information about the Tarantool-patches
mailing list