[Tarantool-patches] [PATCH vshard 4/5] error: introduce from_string

Oleg Babin olegrok at tarantool.org
Fri Dec 17 14:09:46 MSK 2021


Thanks for your patch. LGTM.

However we should probably use more neutral name that doesn't touch 
implementation details.

Maybe in future we will use new native custom errors that are available 
in new Tarantool versions.

So probably it's better to call this method e.g. deserialize. Feel free 
to ignore.

On 17.12.2021 03:25, Vladislav Shpilevoy wrote:
> vshard.storage.call() and most of the other vshard.storage.*
> functions now raise an exception STORAGE_IS_DISABLED when the
> storage is disabled.


More information about the Tarantool-patches mailing list