[Tarantool-patches] [PATCH] replication: fix flaky gh-3160-misc... test

Serge Petrenko sergepetrenko at tarantool.org
Wed Dec 8 14:56:59 MSK 2021



08.12.2021 14:25, Vladimir Davydov пишет:
> On Wed, Dec 08, 2021 at 02:13:04PM +0300, Serge Petrenko wrote:
>>
>> 08.12.2021 14:00, Vladimir Davydov via Tarantool-patches пишет:
>>> Merged into master, 2.8, 1.10.
>>>
>>> Please don't send emails. PR is enough :-)
>> Some people prefer emails over PRs.
>>
>> I think everyone should review the patches where it suits
>> them best, so I open PRs for you and send emails to Vlad.
>> (even though this is double the hustle).
> This is confusing. I noticed the email only after I merged the PR.
> In the PR, I was the only reviewer so I reckoned it's okay to merge,
> but it turned out the patch was also sent to Vlad via email...

Yes, that's my bad. I could've put Vlad into reviewers list as well.

>
> Also, when the same patch is reviewed both via email and PR, the same
> comment might be raised twice by different reviewers or reviewers may
> suggest different things being not aware of each other's arguments and
> you'll have to reconcile.

I agree. Though this particular patch was rather small, so I don't think it
could raise any disputes.

>
> Vlad can review patches in PRs AFAICS - he reviews my patches in PRs,
> for instance.

-- 
Serge Petrenko



More information about the Tarantool-patches mailing list