[Tarantool-patches] [PATCH vshard 1/2] router: drop wait_connected from master discovery

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Tue Dec 7 02:34:35 MSK 2021


Hi! Thanks for the review!

On 05.12.2021 18:44, Oleg Babin wrote:
> Thanks for your patch. Looks reasonable.
> 
> However I have one question. Before this patch if some
> 
> connection was down we perform wait_connected and in some
> 
> cases it could lead to successful reconnection. Currently we just skip
> 
> broken connections and don't try to reconnect.
> 
> Could it be a problem or we perform reconnection in another place?
> 
> What will be happen if all connections will be down?

All connections use reconnect_after option in netbox. Thus netbox
handles reconnect. If all are down, netbox_wait_connected won't help
either. So you will need to make several master discovery iterations
anyway until one is found.

Also before this patch netbox_wait_connected() couldn't boost
successful reconnection anyhow. It was just waiting. It didn't affect
the connection state.

After this patch the waiting is dropped to try to talk to the
disconnected nodes later on a next master discovery iteration.


More information about the Tarantool-patches mailing list