[Tarantool-patches] [PATCH v1 1/1] sql: remove registerTrace() from mem.c

[Mergen Imeev]

On Fri, Dec 03, 2021 at 12:46:34AM +0100, Vladislav Shpilevoy wrote:
> On 01.12.2021 08:59, Mergen Imeev via Tarantool-patches wrote:
> > Hi! Thank you for the review! My answer below.
> > 
> > On Tue, Nov 30, 2021 at 10:00:44PM +0100, Vladislav Shpilevoy wrote:
> >> Hi! Thanks for the patch looks good, but I would drop this 'register trace'
> >> entirely. Everything that uses 'printf' is dead anyway.
> >>
> > I'm not sure about that. For example, I have executed these statements on master and on my branch:
> 
> It is a misunderstanding. I didn't mean you patch does not
> change anything. I meant that this whole mechanism of 'register traces'
> is dead IMO. It is unusable. For example, if you need to debug something
> on a remote server, you won't see these printf() results anyway. Because
> you perhaps will talk to the server using IProto. So whatever the server
> prints to stdout you simply won't see. You will use box.execute EXPLAIN,
> right?
> 
> As 'dead' here I meant useless/unusable/not-worth-the-efforts-of-fixing.
> Not unreachable.
Thank you for the explanation! I will think about what we can do to replace
this functionality by something more useful.